Harden XML parsing, serialization, and randomness#3075
Merged
Conversation
This commit introduces several security hardening improvements across the codebase: 1. XML Processing: Hardened `TransformerFactory` and `SchemaFactory` instantiations in `EppMessage.java` by explicitly enabling `XMLConstants.FEATURE_SECURE_PROCESSING` and disabling external schema access. 2. Randomness: Replaced instances of `java.util.Random` with `java.security.SecureRandom` in `SelfSignedCaCertificate.java` for stronger entropy. (Added documentation in `ProxyModule.java` explaining why `java.util.Random` is intentionally retained there for metrics sampling). 3. Deserialization: Hardened `SerializeUtils.java` by injecting an `ObjectInputFilter` into the `ObjectInputStream`, restricting deserialization strictly to expected `google.registry` classes and standard Java collections.
gbrodman
approved these changes
Jun 1, 2026
Collaborator
gbrodman
left a comment
gbrodman
left a comment
There was a problem hiding this comment.
@gbrodman reviewed 7 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on CydeWeys).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces several security hardening improvements across the codebase:
TransformerFactoryandSchemaFactoryinstantiations inEppMessage.javaby explicitly enablingXMLConstants.FEATURE_SECURE_PROCESSINGand disabling external schema access.java.util.Randomwithjava.security.SecureRandominSelfSignedCaCertificate.javafor stronger entropy. (Added documentation inProxyModule.javaexplaining whyjava.util.Randomis intentionally retained there for metrics sampling).SerializeUtils.javaby injecting anObjectInputFilterinto theObjectInputStream, restricting deserialization strictly to expectedgoogle.registryclasses and standard Java collections.This change is