Skip to content

Add entity for reserved list#381

Merged
hstonec merged 1 commit intogoogle:masterfrom
hstonec:add-entity-for-reserve-list
Nov 26, 2019
Merged

Add entity for reserved list#381
hstonec merged 1 commit intogoogle:masterfrom
hstonec:add-entity-for-reserve-list

Conversation

@hstonec
Copy link
Copy Markdown
Contributor

@hstonec hstonec commented Nov 21, 2019

This PR added the Cloud SQL entity for reserved list.


This change is Reviewable

@hstonec hstonec requested a review from CydeWeys November 21, 2019 20:06
@CydeWeys CydeWeys requested a review from gbrodman November 22, 2019 19:09
Copy link
Copy Markdown
Member

@CydeWeys CydeWeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+reviewer:@gbrodman

Reviewable status: 0 of 6 files reviewed, all discussions resolved (waiting on @CydeWeys and @gbrodman)

Copy link
Copy Markdown
Member

@CydeWeys CydeWeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 6 files reviewed, all discussions resolved (waiting on @gbrodman)

Copy link
Copy Markdown
Collaborator

@gbrodman gbrodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 6 files reviewed, 2 unresolved discussions (waiting on @gbrodman and @hstonec)


core/src/main/java/google/registry/schema/tld/ReservedList.java, line 127 at r1 (raw file):

  public Long getRevisionId() {
    checkState(
        revisionId != null, "revisionId is null because it is not persisted in the database");

nit, something like "revisionId is null because this object has not been persisted to the database yet"


core/src/main/java/google/registry/schema/tld/ReservedList.java, line 137 at r1 (raw file):

  /** Returns a {@link Map} of domain labels to {@link ReservedEntry}. */
  public Map<String, ReservedEntry> getLabelsToReservations() {

nit: wrap in ImmutableMap?

@hstonec hstonec force-pushed the add-entity-for-reserve-list branch from 7dd8fec to 65e4a75 Compare November 26, 2019 21:08
Copy link
Copy Markdown
Contributor Author

@hstonec hstonec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 6 files reviewed, all discussions resolved


core/src/main/java/google/registry/schema/tld/ReservedList.java, line 127 at r1 (raw file):

Previously, gbrodman wrote…

nit, something like "revisionId is null because this object has not been persisted to the database yet"

Done.


core/src/main/java/google/registry/schema/tld/ReservedList.java, line 137 at r1 (raw file):

Previously, gbrodman wrote…

nit: wrap in ImmutableMap?

Done.

@hstonec hstonec merged commit 9be5091 into google:master Nov 26, 2019
@hstonec hstonec deleted the add-entity-for-reserve-list branch November 26, 2019 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants