Conversation
CydeWeys
left a comment
There was a problem hiding this comment.
+reviewer:@gbrodman
Reviewable status: 0 of 6 files reviewed, all discussions resolved (waiting on @CydeWeys and @gbrodman)
CydeWeys
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 6 files reviewed, all discussions resolved (waiting on @gbrodman)
gbrodman
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 6 files reviewed, 2 unresolved discussions (waiting on @gbrodman and @hstonec)
core/src/main/java/google/registry/schema/tld/ReservedList.java, line 127 at r1 (raw file):
public Long getRevisionId() { checkState( revisionId != null, "revisionId is null because it is not persisted in the database");
nit, something like "revisionId is null because this object has not been persisted to the database yet"
core/src/main/java/google/registry/schema/tld/ReservedList.java, line 137 at r1 (raw file):
/** Returns a {@link Map} of domain labels to {@link ReservedEntry}. */ public Map<String, ReservedEntry> getLabelsToReservations() {
nit: wrap in ImmutableMap?
7dd8fec to
65e4a75
Compare
hstonec
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 6 files reviewed, all discussions resolved
core/src/main/java/google/registry/schema/tld/ReservedList.java, line 127 at r1 (raw file):
Previously, gbrodman wrote…
nit, something like "revisionId is null because this object has not been persisted to the database yet"
Done.
core/src/main/java/google/registry/schema/tld/ReservedList.java, line 137 at r1 (raw file):
Previously, gbrodman wrote…
nit: wrap in ImmutableMap?
Done.
This PR added the Cloud SQL entity for reserved list.
This change is