Skip to content
This repository was archived by the owner on Jan 18, 2025. It is now read-only.

Adds support for Google Developer Shell session credentials#143

Merged
nathanielmanistaatgoogle merged 1 commit intogoogleapis:masterfrom
aalexand:support-devshell-credentials
Mar 13, 2015
Merged

Adds support for Google Developer Shell session credentials#143
nathanielmanistaatgoogle merged 1 commit intogoogleapis:masterfrom
aalexand:support-devshell-credentials

Conversation

@aalexand
Copy link
Copy Markdown
Contributor

No description provided.

@googlebot
Copy link
Copy Markdown

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

Comment thread oauth2client/devshell.py Outdated

This comment was marked as spam.

This comment was marked as spam.

@skelterjohn
Copy link
Copy Markdown
Contributor

LGTM. regarding CLA, have you registered as a github googler?

@aalexand
Copy link
Copy Markdown
Contributor Author

have you registered as a github googler?

I think I have now.

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.76%) to 64.72% when pulling 701abfd on aalexand:support-devshell-credentials into 07da0fe on google:master.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.76%) to 64.72% when pulling 0627984 on aalexand:support-devshell-credentials into 07da0fe on google:master.

@nathanielmanistaatgoogle
Copy link
Copy Markdown
Contributor

(I'll be taking a look at this at some point.)

Comment thread oauth2client/devshell.py

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@nathanielmanistaatgoogle
Copy link
Copy Markdown
Contributor

Please squash your commits.

@aalexand aalexand force-pushed the support-devshell-credentials branch from 1aa4b50 to c8eaffa Compare March 11, 2015 05:27
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.73%) to 64.68% when pulling c8eaffa on aalexand:support-devshell-credentials into 07da0fe on google:master.

@nathanielmanistaatgoogle
Copy link
Copy Markdown
Contributor

I'm satisfied (thank you for the changes). Will anyone else be reviewing this before it goes in?

@skelterjohn
Copy link
Copy Markdown
Contributor

changes LGTM as well. let me know if you consider this ready to merge.

@nathanielmanistaatgoogle
Copy link
Copy Markdown
Contributor

I consider this ready to merge.

Last call for obstacles, blockers, and objections?

@aalexand
Copy link
Copy Markdown
Contributor Author

I think it should be merged now.

nathanielmanistaatgoogle added a commit that referenced this pull request Mar 13, 2015
Adds support for Google Developer Shell session credentials
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants