Fix TestDataPathsActivity jitter calculation#2349
Merged
Merged
Conversation
Collaborator
q23175401
commented
Mar 10, 2026
q23175401
commented
- Move jitter calculation from TestDataPathsActivity.java to DataPathAnalyzer.cpp to calcuate scores on each frame instead of in a UI event.
- Add kMinSmoothedMagnitude to align CTSV data paths jitter analyzer.
- Fix sinf to sin for precision.
1. Move jitter calculation from TestDataPathsActivity.java to DataPathAnalyzer.cpp to calcuate scores on each frame instead of in a UI event. 2. Add kMinSmoothedMagnitude to align CTSV data paths jitter analyzer. 3. Fix sinf to sin for precision.
robertwu1
reviewed
Mar 10, 2026
robertwu1
approved these changes
Mar 10, 2026
Collaborator
robertwu1
left a comment
robertwu1
left a comment
There was a problem hiding this comment.
LGTM. Please test the tests I mentioned before submitting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.