Skip to content

go: Eliminate memory allocations and reduce Decode time by 26% #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
willbeason wants to merge 1 commit into
base: main
Choose a base branch
from
Open

go: Eliminate memory allocations and reduce Decode time by 26% #749

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions go/olc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,18 +188,19 @@ func upper(b byte) byte {
// The code is truncated to the first 15 digits, as Decode won't use more,
// to avoid underflow errors.
func StripCode(code string) string {
code = strings.Map(
func(r rune) rune {
if r == Separator || r == Padding {
return -1
}
return rune(upper(byte(r)))
},
code)
if len(code) > maxCodeLen {
return code[:maxCodeLen]
result := make([]byte, maxCodeLen)
pos := 0
for _, r := range code {
if r == Separator || r == Padding {
continue
}
result[pos] = upper(byte(r))
pos++
if pos >= maxCodeLen {
break
}
}
return code
return string(result[:pos])
}

// Because the OLC codes are an area, they can't start at 180 degrees, because they would then have something > 180 as their upper bound.
Expand Down