Skip to content

Docs improvement: change example of ASM json file#129

Merged
jcnars merged 1 commit into
masterfrom
fix_doc_asm_json
Sep 27, 2022
Merged

Docs improvement: change example of ASM json file#129
jcnars merged 1 commit into
masterfrom
fix_doc_asm_json

Conversation

@jcnars
Copy link
Copy Markdown
Contributor

@jcnars jcnars commented Sep 27, 2022

Provide an example of json data that may be less error prone and be readily customized/consumed by customers

@jcnars
Copy link
Copy Markdown
Contributor Author

jcnars commented Sep 27, 2022

/test ?

@google-oss-prow
Copy link
Copy Markdown

@jcnars: The following commands are available to trigger required jobs:

  • /test bms-toolkit-install
Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcnars
Copy link
Copy Markdown
Contributor Author

jcnars commented Sep 27, 2022

/test bms-toolkit-install

@jcnars jcnars requested a review from acolvin September 27, 2022 21:12
@google-oss-prow
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acolvin, jcnars

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jcnars jcnars merged commit 1f99fc8 into master Sep 27, 2022
@jcnars jcnars deleted the fix_doc_asm_json branch September 27, 2022 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants