Skip to content
This repository was archived by the owner on Jan 31, 2025. It is now read-only.

Add CaptureWindowDebugInterface#4401

Merged
beckerhe merged 1 commit intogoogle:mainfrom
beckerhe:capture_window_debug_interface
Nov 16, 2022
Merged

Add CaptureWindowDebugInterface#4401
beckerhe merged 1 commit intogoogle:mainfrom
beckerhe:capture_window_debug_interface

Conversation

@beckerhe
Copy link
Collaborator

@beckerhe beckerhe commented Nov 16, 2022

This is adding the CaptureWindowDebugInterface and implementing it for CaptureWindow.

There are 3 getter in the interface that return various pieces of information about the state of the capture window.
It is meant for developing purposes only and is going to replace the RenderImGuiDebugUI method in CaptureWindow which is compiling the same pieces of information. The logic is basically a copy of what currently is in RenderImGuiDebugUI.

@beckerhe beckerhe force-pushed the capture_window_debug_interface branch from 0a18550 to a64892d Compare November 16, 2022 10:28
@beckerhe beckerhe marked this pull request as ready for review November 16, 2022 12:31
Copy link
Collaborator

@danielfenner danielfenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm1

@beckerhe beckerhe merged commit 7cba265 into google:main Nov 16, 2022
@beckerhe beckerhe deleted the capture_window_debug_interface branch November 16, 2022 12:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants