pcre2: add run_tests.sh#13636
Merged
DavidKorczynski merged 1 commit intogoogle:masterfrom Jul 17, 2025
Merged
Conversation
Signed-off-by: Adam Korczynski <adam@adalogics.com>
Collaborator
Author
|
@addisoncrump @PhilipHazel do you see any reason that increasing the match limit depth will have a negative impact on the fuzzers? |
Contributor
|
I suspect it will increase the number of timeouts. Note: I am no longer
working on PCRE2.
Regards,
Philip
…On Tue, 15 Jul 2025 at 20:57, AdamKorcz ***@***.***> wrote:
*AdamKorcz* left a comment (google/oss-fuzz#13636)
<#13636 (comment)>
@addisoncrump <https://github.com/addisoncrump> @PhilipHazel
<https://github.com/PhilipHazel> do you see any reason that increasing
the match limit depth will have a negative impact on the fuzzers?
—
Reply to this email directly, view it on GitHub
<#13636 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AG4QUAGSVYHKJXAK7JNF6XD3IVMJRAVCNFSM6AAAAACBS4MZ7CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTANZVGMYTQMJXGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
DavidKorczynski
approved these changes
Jul 17, 2025
Collaborator
DavidKorczynski
left a comment
There was a problem hiding this comment.
LGTM. The change to --with-match-limit is to enable the tests to pass, which is needed for Chronos. If the consequences is an unreasonable number of timeouts or similar in the harness then we'll have to address in follow ups.
Contributor
|
Bit late to the party, but yes, the match limit was reduced to reduce the number of timeouts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds run_tests.sh to the pcre2 project.
The PR changes the max match limit. Otherwise the tests fail.
run_tests.shis used as part of Chronos with cached builds: https://github.com/google/oss-fuzz/tree/master/infra/experimental/chronos#check-testsinfra/experimental/chronos/check_tests.sh pcre2 c