Skip to content

pcre2: add run_tests.sh#13636

Merged
DavidKorczynski merged 1 commit intogoogle:masterfrom
AdamKorcz:icu-run-tests.sh
Jul 17, 2025
Merged

pcre2: add run_tests.sh#13636
DavidKorczynski merged 1 commit intogoogle:masterfrom
AdamKorcz:icu-run-tests.sh

Conversation

@AdamKorcz
Copy link
Copy Markdown
Collaborator

Adds run_tests.sh to the pcre2 project.

The PR changes the max match limit. Otherwise the tests fail.

run_tests.sh is used as part of Chronos with cached builds: https://github.com/google/oss-fuzz/tree/master/infra/experimental/chronos#check-tests

infra/experimental/chronos/check_tests.sh pcre2 c

...
PASS: pcre2posix_test                                                        
PASS: pcre2_jit_test                                                                                                                                       
PASS: RunTest                                                                
PASS: RunGrepTest                                                            
============================================================================ 
Testsuite summary for PCRE2 10.46-DEV                                        
============================================================================ 
# TOTAL: 4                                                                                                                                                 
# PASS:  4                                                                                                                                                 
# SKIP:  0                                                                   
# XFAIL: 0                                                                   
# FAIL:  0                                                                                                                                                 
# XPASS: 0                                                                   
# ERROR: 0                                                                   
============================================================================
make[3]: Leaving directory '/src/pcre2'                                                                                                                    
make[2]: Leaving directory '/src/pcre2'                                      
make[1]: Leaving directory '/src/pcre2'

Signed-off-by: Adam Korczynski <adam@adalogics.com>
@AdamKorcz
Copy link
Copy Markdown
Collaborator Author

@addisoncrump @PhilipHazel do you see any reason that increasing the match limit depth will have a negative impact on the fuzzers?

@PhilipHazel
Copy link
Copy Markdown
Contributor

PhilipHazel commented Jul 17, 2025 via email

Copy link
Copy Markdown
Collaborator

@DavidKorczynski DavidKorczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The change to --with-match-limit is to enable the tests to pass, which is needed for Chronos. If the consequences is an unreasonable number of timeouts or similar in the harness then we'll have to address in follow ups.

@DavidKorczynski DavidKorczynski merged commit 5bd8bc1 into google:master Jul 17, 2025
16 checks passed
@addisoncrump
Copy link
Copy Markdown
Contributor

Bit late to the party, but yes, the match limit was reduced to reduce the number of timeouts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants