infra: base-builder: compile: wrap find names in quotes#8943
Merged
Conversation
Wrap wildcards in quotes as otherwise the script will autocomplete if there is a e.g. .json file in the current directory. This causes the wrong files to be moved, which means `all_cov.json` will not be moved to the introspector folder and thus wrong (no) coverage data will be used. This error happens in e.g. g-api-auth-library-python
Contributor
|
Nice catch! |
Collaborator
Author
|
Do we need trail builds for this? Otherwise this one should be good to go |
Collaborator
|
/gcbrun trial_build.py htslib aspell zlib yara xpdf --sanitizer introspector --fuzzing-engine libfuzzer --force |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrap wildcards in quotes as otherwise the script will autocomplete if there is a e.g. .json file in the current directory. This causes the wrong files to be moved, which means
all_cov.jsonwill not be moved to the introspector folder and thus wrong (no) coverage data will be used.This error happens in e.g. g-api-auth-library-python