Skip to content

feat: enable swift/packageresolved plugin to detect SwiftURL vulnerabilities#2801

Merged
another-rex merged 6 commits into
google:mainfrom
herdiyana256:feature/enable-swift-packageresolved-plugin
May 18, 2026
Merged

feat: enable swift/packageresolved plugin to detect SwiftURL vulnerabilities#2801
another-rex merged 6 commits into
google:mainfrom
herdiyana256:feature/enable-swift-packageresolved-plugin

Conversation

@herdiyana256
Copy link
Copy Markdown
Contributor

Follow-up to google/osv-scalibr#2034 which fixed the purl type for swift/packageresolved.

This PR:

  1. Bumps google/osv-scalibr to include the fix (commit d13148df68e0).
  2. Enables the swift/packageresolved plugin in osv-scanner presets.
  3. Adds an E2E test verifying successful detection of SwiftURL advisories, including GHSA-84m3-f99p-cqx5 (executorch) and GHSA-xvr7-p2c6-j83w (swift-nio-http2).

Testing:

  • go test ./cmd/osv-scanner/scan/source/... passes with expected E2E CVE detections.

@another-rex
Copy link
Copy Markdown
Collaborator

Can you try rebasing on the new go.mod. Hopefully that'll fix the CI issues.

@herdiyana256 herdiyana256 force-pushed the feature/enable-swift-packageresolved-plugin branch from cd2246f to 5d6a50b Compare May 15, 2026 03:31
@herdiyana256
Copy link
Copy Markdown
Contributor Author

Hi @another-rex,

done! Branch has been rebased onto the latest go.mod from upstream main (5a15332).

Ready for CI approval.

Thank you!

@another-rex
Copy link
Copy Markdown
Collaborator

Thanks for resolving the unrelated issue with the govulncheck update. I might pull that into a separate PR just to keep the commits clean.

Enable the swift/packageresolved extractor plugin in the default lockfile
preset so that Package.resolved files are automatically scanned for
SwiftURL ecosystem vulnerabilities.

Add E2E test cases demonstrating successful detection of:
- GHSA-84m3-f99p-cqx5 (github.com/pytorch/executorch 0.6.0, Critical 9.8)
- GHSA-xvr7-p2c6-j83w (github.com/apple/swift-nio-http2 1.19.1, Medium 6.3)
- Plus 10 additional SwiftURL advisories across the 2 test fixtures

Total: 12 SwiftURL vulnerabilities detected from 2 packages.

Follow-up to google/osv-scalibr#2034 as requested by @another-rex.

Note: After google/osv-scalibr#2034 is merged via copybara, run:
  go get github.com/google/osv-scalibr@latest && go mod tidy
before opening this PR upstream.
@herdiyana256 herdiyana256 force-pushed the feature/enable-swift-packageresolved-plugin branch from 3d13abd to 4a7d22c Compare May 15, 2026 08:15
@herdiyana256
Copy link
Copy Markdown
Contributor Author

@another-rex, rebased again on latest main (b170227). Ready for CI re-approval. Thank you for your patience!

@another-rex another-rex force-pushed the feature/enable-swift-packageresolved-plugin branch from 9f5f5f2 to e608d53 Compare May 18, 2026 01:36
@another-rex another-rex enabled auto-merge (squash) May 18, 2026 01:38
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.59%. Comparing base (1d38ab4) to head (e608d53).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2801      +/-   ##
==========================================
- Coverage   79.09%   78.59%   -0.51%     
==========================================
  Files         121      121              
  Lines        8185     8185              
==========================================
- Hits         6474     6433      -41     
- Misses       1327     1374      +47     
+ Partials      384      378       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@another-rex another-rex disabled auto-merge May 18, 2026 01:54
@another-rex another-rex merged commit bea4a3e into google:main May 18, 2026
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants