Support a conversion/extraction corner case as usable#2214
Merged
andrewpollock merged 3 commits intogoogle:masterfrom May 16, 2024
Merged
Support a conversion/extraction corner case as usable#2214andrewpollock merged 3 commits intogoogle:masterfrom
andrewpollock merged 3 commits intogoogle:masterfrom
Conversation
There is a corner case where there was an unresolvable `last_affected` version, but a(n assumed) `fixed` commit (extracted from reference URLs most commonly) and so the failure to resolve the `last_affected` shouldn't be treated as unusable data overall for conversion.
Order the work so it's only done if necessary, and add the previous edge case fix to CVEToOSV as well.
oliverchang
approved these changes
May 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a corner case where there was an unresolvable
last_affectedversion, but a(n assumed)fixedcommit (extracted from reference URLs most commonly) and so the failure to resolve thelast_affectedshouldn't be treated as unusable data overall for conversion.Harmonize the ordering of potentially unnecessary work in CVEToPackageInfo and CVEToOSV