Skip to content

Fix bug with early termination processing references #2228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewpollock merged 2 commits into from
May 22, 2024
Merged

Fix bug with early termination processing references #2228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03f1b77
Fix bug with early termination processing references
andrewpollock May 22, 2024
b23d995
Merge branch 'master' into test_CVE-2021-23568
andrewpollock May 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion vulnfeeds/cmd/nvd-cve-osv/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ func ReposFromReferences(CVE string, cache VendorProductToRepoMap, vp *VendorPro
// Also remove it if previously added under an acceptable tag.
maybeRemoveFromVPRepoCache(cache, vp, ref.Url)
Logger.Infof("[%s]: disregarding %q for %q due to a denied tag in %q", CVE, ref.Url, vp, ref.Tags)
break
continue
}
repo, err := cves.Repo(ref.Url)
if err != nil {
Expand Down
9 changes: 9 additions & 0 deletions vulnfeeds/cves/versions_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,6 +597,15 @@ func TestExtractGitCommit(t *testing.T) {
Fixed: "37deefd01f0875e133ea967122e3a5e421b8fcd9",
},
},
{
description: "A GitHub repo that should be working (as seen on CVE-2021-23568)",
inputLink: "https://github.com/eggjs/extend2/commit/aa332a59116c8398976434b57ea477c6823054f8",
inputCommitType: Fixed,
expectedAffectedCommit: AffectedCommit{
Repo: "https://github.com/eggjs/extend2",
Fixed: "aa332a59116c8398976434b57ea477c6823054f8",
},
},
}

for _, tc := range tests {
Expand Down