Initial v2 UI#280
Merged
oliverchang merged 5 commits intogoogle:masterfrom Jan 27, 2022
Merged
Conversation
oliverchang
reviewed
Jan 19, 2022
Collaborator
oliverchang
left a comment
oliverchang
left a comment
There was a problem hiding this comment.
Thanks a lot! This is AMAZING!!!
Just some initial comments on the Python code around re-use, but otherwise this looks incredible already.
| response = requests.get('https://osv.dev/backend/vulnerability?id=%s' % id) | ||
| item = json.loads(response.content) | ||
|
|
||
| vulnerability = { |
Collaborator
There was a problem hiding this comment.
Can we just return the vulnerability structure as-is, without doing this field mapping here? The structure format is stable and based on https://ossf.github.io/osv-schema/.
Contributor
Author
There was a problem hiding this comment.
SG, shall we do the same for the vuln list? From a look at the API it does look the same
Contributor
|
Thanks a ton Richard (@rzhw) for working on this OSV v2 UI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR starts work on #231 and partially implements the design. More work to be left for followup PRs.
Screenshots: