Support schema version 1.2.0#285
Merged
oliverchang merged 4 commits intomasterfrom Jan 24, 2022
Merged
Conversation
Also delete legacy code dealing with pre-1.0 schema. Fixes #284.
inferno-chromium
approved these changes
Jan 24, 2022
| // The type of this severity entry. | ||
| Type type = 1; | ||
| // The quantitative score. | ||
| string score = 2; |
Contributor
There was a problem hiding this comment.
if it is quantitative score, then shouldn't this be int or float ?
Collaborator
Author
There was a problem hiding this comment.
This is a string for future extensibility, or if we relax the "quantitative" requirement.
| message Credit { | ||
| // The name to give credit to. | ||
| string name = 1; | ||
| // Contact methods. |
Contributor
There was a problem hiding this comment.
should the comment have example of methods ?
Collaborator
Author
There was a problem hiding this comment.
Clarified this to be URLs. This is all better documented at https://ossf.github.io/osv-schema/ :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also delete legacy code dealing with pre-1.0 schema.
Fixes #284.