Skip to content

Initial v2 infinite load implementation #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oliverchang merged 7 commits into from
Feb 6, 2022
Merged

Initial v2 infinite load implementation #289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1cace77
redo vuln table as divs
rzhw Feb 2, 2022
bf67114
hello infinite loading
rzhw Feb 2, 2022
3648a2d
styling and load indicator for the button
rzhw Feb 4, 2022
36d9ec8
lint
rzhw Feb 4, 2022
b4af0bc
apply vertical align mdidle
rzhw Feb 4, 2022
1269cac
remove erroneous <table>
rzhw Feb 4, 2022
f6d68af
consistency
rzhw Feb 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
191 changes: 191 additions & 0 deletions gcp/appengine/frontend3/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions gcp/appengine/frontend3/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
"@hotwired/turbo": "^7.1.0",
"@material/data-table": "^13.0.0",
"@material/layout-grid": "^13.0.0",
"@material/mwc-circular-progress": "^0.25.3",
"@material/mwc-icon": "^0.25.3",
"@material/mwc-icon-button": "^0.25.3",
"@material/mwc-textfield": "^0.25.3",
Expand Down
1 change: 1 addition & 0 deletions gcp/appengine/frontend3/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import './styles.scss';
import '@material/mwc-circular-progress';
import '@material/mwc-icon';
import '@material/mwc-icon-button';
import '@material/mwc-textfield';
Expand Down
43 changes: 39 additions & 4 deletions gcp/appengine/frontend3/src/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ body {
color: $osv-text-color;
font-family: $osv-font-family;
font-size: 14px;
--mdc-theme-primary: $osv-text-color;
--mdc-theme-primary: #{$osv-text-color};
--mdc-theme-surface: $osv-background;
--mdc-theme-background: $osv-background;
--mdc-typography-font-family: $osv-font-family;
Expand All @@ -80,6 +80,17 @@ turbo-frame {
display: contents;
}

.link-button {
display: inline-flex;
padding: 0 16px;
height: 36px;
background: $osv-accent-color;
color: $osv-text-color;
border-radius: 4px;
align-items: center;
text-decoration: none;
}

/** WIP notice */

.wip-notice {
Expand Down Expand Up @@ -176,10 +187,34 @@ mwc-icon-button.mdc-data-table__sort-icon-button {

.vuln-table-container {
// The vulnerability list should be full-width but not overflow the page bounds.
@include full-width;
overflow-x: scroll;
width: 100%;

// Apply table display etc.
.vuln-table {
overflow-x: scroll;
width: 100%;
display: table;
}
.vuln-table-header {
display: table-header-group;
}
.vuln-table-rows {
display: table-row-group;
}
.vuln-table-row {
display: table-row;
}
.vuln-table-cell {
display: table-cell;
vertical-align: middle;
}

// Swap next page button/loading indicator as needed.
turbo-frame .next-page-indicator,
turbo-frame[busy] .next-page-button {
display: none;
}
turbo-frame[busy] .next-page-indicator {
display: block;
}
}

Expand Down
Loading