Properly support "withdrawn".#295
Merged
oliverchang merged 2 commits intomasterfrom Feb 14, 2022
Merged
Conversation
oliverchang
commented
Feb 14, 2022
| versions.extend(affected.versions) | ||
|
|
||
| if vulnerability.HasField('withdrawn'): | ||
| events = [] |
Collaborator
Author
There was a problem hiding this comment.
@di this is the expected behaviour right?
Member
There was a problem hiding this comment.
We don't really care about events unless the vulnerability is marked as fixed, the important thing is versions = [] on the line below 👍
- Set "withdrawn" vulnerabilities to invalid to prevent them from surfacing in API results and UI. - Handle sending "withdrawn" vulnerabilities to PyPI. Also improve version aggregation while we're here. Fixes #290.
oliverchang
force-pushed
the
withdrawn
branch
from
36d95ea to
f7adb38
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
surfacing in API results and UI.
version aggregation while we're here.
Fixes #290.