feat(nvd): Add functions to help monitor performance - ConductAnalysis and CpuProfile#4817
Merged
jess-lowe merged 3 commits intogoogle:masterfrom Feb 17, 2026
Merged
Conversation
jess-lowe
requested review from
Ly-Joey,
another-rex,
cuixq and
michaelkedar
tobyhawker
previously approved these changes
Feb 16, 2026
michaelkedar
approved these changes
Feb 17, 2026
Comment on lines
+58
to
70
| if *cpuProfile != "" { | ||
| f, err := os.Create(*cpuProfile) | ||
| if err != nil { | ||
| logger.Fatal("could not create CPU profile: ", slog.Any("err", err)) | ||
| } | ||
| defer f.Close() | ||
| if err := pprof.StartCPUProfile(f); err != nil { | ||
| logger.Fatal("could not start CPU profile: ", slog.Any("err", err)) | ||
| } | ||
| defer pprof.StopCPUProfile() | ||
| } | ||
|
|
||
| logger.InitGlobalLogger() |
Member
There was a problem hiding this comment.
nit: setting up the profiler should probably go after logger.InitGlobalLogger() (though it doesn't actually make a difference)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added CPU profiling to nvd conversion so we can easily check what's taking the most time, and ConductAnalysis, which runs through all of the outputted metrics files after conversion runs and produces a CSV file on the outcomes.