fix(website): correct external nav link targets#5028
Merged
another-rex merged 1 commit intogoogle:masterfrom Mar 13, 2026
Merged
fix(website): correct external nav link targets#5028another-rex merged 1 commit intogoogle:masterfrom
another-rex merged 1 commit intogoogle:masterfrom
Conversation
another-rex
approved these changes
Mar 13, 2026
Contributor
|
Huh interesting, wonder how those got there haha. |
tymzd
pushed a commit
to tymzd/osv.dev
that referenced
this pull request
Apr 13, 2026
The target attributes in the website header were using curly quotes instead of normal ones which made the new tab behavior broken (both links would open in the same new tab).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The target attributes in the website header were using curly quotes instead of normal ones which made the new tab behavior broken (both links would open in the same new tab).