fix: skip vulnerabilities with empty affected ranges in combine-to-osv#5039
Merged
jess-lowe merged 2 commits intogoogle:masterfrom Mar 13, 2026
Conversation
Added a helper `hasRanges` to ensure that vulnerabilities missing ranges in their `affected` blocks are skipped and not uploaded unless they are explicitly included in the `mandatoryCVEIDs` slice. Also updated `main_test.go` to assert this new logic correctly. Co-authored-by: jess-lowe <86962800+jess-lowe@users.noreply.github.com>
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
jess-lowe
requested review from
another-rex,
cuixq and
michaelkedar
and removed request for
another-rex
Added a blank line before the `return false` statement in the `hasRanges` function to satisfy the `nlreturn` golangci-lint check. Co-authored-by: jess-lowe <86962800+jess-lowe@users.noreply.github.com>
cuixq
approved these changes
Mar 13, 2026
tymzd
pushed a commit
to tymzd/osv.dev
that referenced
this pull request
Apr 13, 2026
google#5039) Added a helper `hasRanges` to ensure that vulnerabilities missing ranges in their `affected` blocks are skipped and not uploaded unless they are explicitly included in the `mandatoryCVEIDs` slice. Also updated `main_test.go` to assert this new logic correctly. deals with https://osv.dev/vulnerability/CVE-2024-2002 having no ranges --------- Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a helper
hasRangesto ensure that vulnerabilities missing ranges in theiraffectedblocks are skipped and not uploaded unless they are explicitly included in themandatoryCVEIDsslice. Also updatedmain_test.goto assert this new logic correctly.deals with https://osv.dev/vulnerability/CVE-2024-2002 having no ranges