Merged
Conversation
another-rex
approved these changes
Mar 26, 2026
michaelkedar
approved these changes
Mar 26, 2026
tymzd
pushed a commit
to tymzd/osv.dev
that referenced
this pull request
Apr 13, 2026
This PR improves the previous setup logic for gitter in `osv/tests.py`: - Implements a 60-second maximum wait time to accommodate compilation/startup in CI environments. - Uses `socket.connect_ex` to verify the port is open before proceeding. - Prints the exact time taken for the service to become ready.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the previous setup logic for gitter in
osv/tests.py:socket.connect_exto verify the port is open before proceeding.