Update extractor to return LayerDecoder.#1979
Merged
PriyankaSPX merged 1 commit intomainfrom Jul 1, 2025
Merged
Conversation
LalitMaganti
approved these changes
Jul 1, 2025
src/trace_processor/importers/proto/winscope/surfaceflinger_layers_extractor.cc
Outdated
Show resolved
Hide resolved
For greater clarity. Also use optional Rect instead of pointer in GetCroppedScreenBounds. Bug: 411363817 Test: tools/diff_test_trace_processor.py out/linux_clang_debug/trace_processor_shell
PriyankaSPX
force-pushed
the
dev/priyankaspatel/extractorupdate
branch
from
b179969 to
ac7bf62
Compare
olehkuznetsov
pushed a commit
to olehkuznetsov/perfetto
that referenced
this pull request
Mar 12, 2026
LayerDecoder provides greater clarity than ConstBytes. Also use optional Rect instead of pointer in GetCroppedScreenBounds. Bug: 411363817 Test: tools/diff_test_trace_processor.py out/linux_clang_debug/trace_processor_shell
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LayerDecoder provides greater clarity than ConstBytes. Also use optional Rect instead of pointer in GetCroppedScreenBounds.
Bug: 411363817
Test: tools/diff_test_trace_processor.py out/linux_clang_debug/trace_processor_shell