Add CUJ counters to stdlib.#1992
Merged
LalitMaganti merged 3 commits intogoogle:mainfrom Jul 11, 2025
Merged
Conversation
aMayzner
requested changes
Jul 2, 2025
src/trace_processor/perfetto_sql/stdlib/android/cujs/sysui_cuj_counters.sql
Show resolved
Hide resolved
src/trace_processor/perfetto_sql/stdlib/android/cujs/sysui_cuj_counters.sql
Show resolved
Hide resolved
Move CUJ counter information to perfetto stdlib. Remove local tables outside the stdlib, and eventually remove src/trace_processor/metrics/sql/android/jank/internal/counters.sql. Bug: 400855183 Test: tools/diff_test_trace_processor.py --keep-input --name-filter ".*android_jank_cuj\b" out/linux_clang_debug/trace_processor_shell
LalitMaganti
approved these changes
Jul 2, 2025
aMayzner
approved these changes
Jul 2, 2025
nicomazz
approved these changes
Jul 2, 2025
src/trace_processor/perfetto_sql/stdlib/android/cujs/sysui_cuj_counters.sql
Outdated
Show resolved
Hide resolved
src/trace_processor/perfetto_sql/stdlib/android/cujs/sysui_cuj_counters.sql
Show resolved
Hide resolved
src/trace_processor/perfetto_sql/stdlib/android/cujs/sysui_cuj_counters.sql
Show resolved
Hide resolved
src/trace_processor/perfetto_sql/stdlib/android/cujs/sysui_cuj_counters.sql
Show resolved
Hide resolved
devianb
force-pushed
the
stdlib_migration
branch
from
1353fdb to
4ff760d
Compare
LalitMaganti
pushed a commit
that referenced
this pull request
Oct 8, 2025
devianb
added a commit
that referenced
this pull request
Dec 2, 2025
The original change was reverted as counter metrics reported were incorrect in certain cases, due to different cuj_ids in the sysui jank table. The change is re-applied now, but using the android_jank_cujs base table from stdlib, instead of the android_sysui_jank_latency_cujs table. Test: tools/diff_test_trace_processor.py --keep-input --name-filter ".*android_jank_cuj\b" out/linux_clang_debug/trace_processor_shell
devianb
added a commit
that referenced
this pull request
Dec 11, 2025
The original change was reverted as counter metrics reported were incorrect in certain cases, due to different cuj_ids in the sysui jank table. The change is re-applied now, but using the android_jank_cujs base table from stdlib, instead of the android_sysui_jank_latency_cujs table. Test: tools/diff_test_trace_processor.py --keep-input --name-filter ".*android_jank_cuj\b" out/linux_clang_debug/trace_processor_shell
devianb
added a commit
that referenced
this pull request
Dec 13, 2025
The original change was reverted as counter metrics reported were incorrect in certain cases, due to different cuj_ids in the sysui jank table. The change is re-applied now, but using the android_jank_cujs base table from stdlib, instead of the android_sysui_jank_latency_cujs table. Test: tools/diff_test_trace_processor.py --keep-input --name-filter ".*android_jank_cuj\b" out/linux_clang_debug/trace_processor_shell
olehkuznetsov
pushed a commit
to olehkuznetsov/perfetto
that referenced
this pull request
Mar 12, 2026
Move CUJ counter information to perfetto stdlib. Remove local tables outside the stdlib, and eventually remove src/trace_processor/metrics/sql/android/jank/internal/counters.sql. Bug: 400855183 Test: tools/diff_test_trace_processor.py --keep-input --name-filter ".*android_jank_cuj\b" out/linux_clang_debug/trace_processor_shell
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move CUJ counter information to perfetto stdlib. Remove local tables outside the stdlib, and eventually remove
src/trace_processor/metrics/sql/android/jank/internal/counters.sql.
Bug: 400855183
Test: tools/diff_test_trace_processor.py --keep-input --name-filter ".*android_jank_cuj\b" out/linux_clang_debug/trace_processor_shell