ui: Move sqlmodules load out of the traceload hotpath#2109
Merged
stevegolton merged 1 commit intomainfrom Jul 10, 2025
Merged
Conversation
This patch moves the SQL modules definition loading to onActivate, so that it's done once on app load rather than having to do it on every trace load. This means we only load the definitions once, and also we also get a head start loading the modules, as we can load in parallel with the rest of the app starting up / trace loading. This does mean that the definitions are possibly undefined, but everywhere that uses the definitions has now been modified to handle this maybe undefined case. Change-Id: I3210c37280fcbf1ad4d1dd2149bc583cd19a264c
LalitMaganti
approved these changes
Jul 10, 2025
aMayzner
approved these changes
Jul 10, 2025
Member
|
Steve: can we land this? |
olehkuznetsov
pushed a commit
to olehkuznetsov/perfetto
that referenced
this pull request
Mar 12, 2026
This fix should speed up trace load times significantly. This patch moves the SQL modules definition loading to onActivate, so that it's done once on app load rather than having to do it on every trace load. This means we only load the definitions once, and also we also get a head start loading the modules, as we can load in parallel with the rest of the app starting up / trace loading. This does mean that the definitions are possibly undefined, but everywhere that uses the definitions has now been modified to handle this maybe undefined case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix should speed up trace load times significantly.
This patch moves the SQL modules definition loading to onActivate, so that it's done once on app load rather than having to do it on every trace load. This means we only load the definitions once, and also we also get a head start loading the modules, as we can load in parallel with the rest of the app starting up / trace loading.
This does mean that the definitions are possibly undefined, but everywhere that uses the definitions has now been modified to handle this maybe undefined case.