Skip to content

tp: remove some dead code and incorrect process track translation#2117

Merged
LalitMaganti merged 3 commits intomainfrom
dev/lalitm/track-event
Jul 11, 2025
Merged

tp: remove some dead code and incorrect process track translation#2117
LalitMaganti merged 3 commits intomainfrom
dev/lalitm/track-event

Conversation

@LalitMaganti
Copy link
Member

  • the event update code should never be reached, just remove it
  • the name for the track was being translated even when it shouldn't
    i.e. for a global track

Allows for separate intern/begin/end/scoped calls which is what will be
needed for trackevent.
* the event update code should never be reached, just remove it
* the name for the track was being translated even when it shouldn't
  i.e. for a global track
@LalitMaganti LalitMaganti requested a review from a team as a code owner July 10, 2025 14:11
@LalitMaganti LalitMaganti requested a review from aMayzner July 10, 2025 14:11
Base automatically changed from dev/lalitm/track-id to main July 10, 2025 16:42
@LalitMaganti LalitMaganti merged commit 5dec6e9 into main Jul 11, 2025
17 of 18 checks passed
@LalitMaganti LalitMaganti deleted the dev/lalitm/track-event branch July 11, 2025 10:04
olehkuznetsov pushed a commit to olehkuznetsov/perfetto that referenced this pull request Mar 12, 2026
…ogle#2117)

* the event update code should never be reached, just remove it
* the name for the track was being translated even when it shouldn't
  i.e. for a global track
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants