Merged
Conversation
Scroll the table not the toolbar, which means the paging controls stay put when scrolling large tables, and the table header stays pinned to the top. Also fixed the widget layout to hide the overflow, limiting the size of widgets so that they get a chance to overflow and demonstrate scrolling. Tested in the following places: - Aggregation panels - Query page - Queries in the tab drawer - Widgets page - Explore page Change-Id: I467a25ad2c061fca7dad1510d733cc87285f5f5a
LalitMaganti
approved these changes
Jul 10, 2025
olehkuznetsov
pushed a commit
to olehkuznetsov/perfetto
that referenced
this pull request
Mar 12, 2026
Fixed the datagrid's css so that the table scrolls, not the toolbar when space is limited, which means the toolbar / paging controls stay put and the table header stays pinned to the top when scrolling large pages. Also fixed the widget layout to hide the overflow, limiting the size of widgets so that they get a chance to overflow and demonstrate scrolling. Tested in the following places: - Aggregation panels - Query page - Queries in the tab drawer - Widgets page - Explore page Demo - notice the paging controls stay put while scrolling the table, and the table header sticks to the top when scrolling vertically, but says aligned with the columns when scrolling horizontally. [e4c3f120-663d-4f3c-80f2-b79a45a1928f.webm](https://github.com/user-attachments/assets/30e445fe-4677-46a4-ab7e-c471d41e080e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the datagrid's css so that the table scrolls, not the toolbar when space is limited, which means the toolbar / paging controls stay put and the table header stays pinned to the top when scrolling large pages.
Also fixed the widget layout to hide the overflow, limiting the size of widgets so that they get a chance to overflow and demonstrate scrolling.
Tested in the following places:
Demo - notice the paging controls stay put while scrolling the table, and the table header sticks to the top when scrolling vertically, but says aligned with the columns when scrolling horizontally.
e4c3f120-663d-4f3c-80f2-b79a45a1928f.webm