UI: add file picker to the Download link in the sidebar#2128
Merged
Conversation
Bug: b/430934358
primiano
force-pushed
the
dev/primiano/uisaveas
branch
from
a3b7beb to
d1c6f9c
Compare
primiano
changed the title
stevegolton
reviewed
Jul 10, 2025
Member
stevegolton
left a comment
stevegolton
left a comment
There was a problem hiding this comment.
Are we OK with using experimental features?
https://developer.mozilla.org/en-US/docs/Web/API/Window/showSaveFilePicker
Also just to note that folks will require two clicks to download a file now.
stevegolton
approved these changes
Jul 10, 2025
Member
Author
As long as we have a fallback I think it's okay. |
olehkuznetsov
pushed a commit
to olehkuznetsov/perfetto
that referenced
this pull request
Mar 12, 2026
Also fix a bug in postmessage_handler, where we ignore localOnly: false, giving no option to the embedder to allow downloads. Bug: b/430934358
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fix a bug in postmessage_handler, where we ignore
localOnly: false, giving no option to the embedder to allow downloads.
Bug: b/430934358