ui: Fix flow arrowhead rendering for vertical arrow separation#2802
Merged
stevegolton merged 3 commits intomainfrom Sep 3, 2025
Merged
ui: Fix flow arrowhead rendering for vertical arrow separation#2802stevegolton merged 3 commits intomainfrom
stevegolton merged 3 commits intomainfrom
Conversation
Currently, flow arrowheads are omitted when the start and end points are close together, but the proximity check only considers the x-axis distance. This causes arrowheads to be hidden even when flows span different tracks with adequate vertical separation, making it difficult to discern arrow direction. This patch calculates the Manhattan distance between start and end points instead of using only the x-axis distance to determine whether to render the arrowhead. Change-Id: I5e639705d2d8417f2bfaa3eb371249492ba6eced
|
🤖 Hi @stevegolton, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
LalitMaganti
approved these changes
Sep 2, 2025
…ther the arrow is long enough in either axis, rather than using Manhattan distance Change-Id: I0093d798dbc6c0cd210262b347e059a06a6fe7cd
Change-Id: I4391d4b1ef0e575c6b473343f84207316fef32a8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, flow arrowheads are omitted when the start and end points are close together, but the proximity check only considers the x-axis distance. This causes arrowheads to be hidden even when flows span different tracks with adequate vertical separation, making it difficult to discern arrow direction.
This patch calculates wether the start and end points are far enough away in either axis, instead of using only the x-axis distance to determine whether to render the arrowhead.
Also fixed a bug in the arrowhead rendering logic where the arrow body emerges from the arrowhead tip instead of the back of the arrowhead.
Before:
Arrowhead presence logic fised (but with arrowhead rendering bug):
Final:
