Merged
Conversation
headless track. Change-Id: I270f57f8666d2931887f34fc27f498dd6666402c
|
🤖 Hi @stevegolton, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
📋 Review Summary
This pull request refactors the track rendering logic to correctly handle headless tracks, preventing them from being selectable. The changes are clear, concise, and improve the maintainability of the code.
🔍 General Feedback
- The logic for handling headless tracks is now much cleaner and easier to understand.
- The change to an IIFE for
isTrackOnScreenis a minor stylistic improvement.
LalitMaganti
approved these changes
Sep 3, 2025
rsavitski
approved these changes
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When selecting over a headless track (users are unaware of this because headless tracks are invisible), the entire group is selected as this is the behavior when selecting over a non-headless track.
This patch fixes the issue by omitting headless tracks from the rendered track list so the selection logic never even sees them.
Fixes: https://buganizer.corp.google.com/issues/442408089