perfetto: heap_profile: introduce android subcommand#5047
Merged
LalitMaganti merged 4 commits intomainfrom Mar 12, 2026
Merged
Conversation
🎨 Perfetto UI Builds
|
LalitMaganti
force-pushed
the
dev/lalitm/heap-profile-3
branch
from
5bbd366 to
b8a5ce8
Compare
rsavitski
approved these changes
Mar 12, 2026
traceconv writes its output (including the "Wrote profiles to <path>" line) to stderr, not stdout. subprocess.check_output() only captures stdout by default, so the profile path was never found and the script always reported "No profiles generated" even when profiles existed. Fix by passing stderr=subprocess.STDOUT so both streams are captured.
Restructure heap_profile to use argparse subparsers. A shared common_parser holds all flags; the 'android' subcommand inherits from it via parents=[common]. When no subcommand is given the tool defaults to 'android', so all existing invocations continue to work unchanged. This prepares the tool for a future 'host' subcommand for local Linux profiling.
LalitMaganti
force-pushed
the
dev/lalitm/heap-profile-2
branch
from
b062d18 to
70427c7
Compare
LalitMaganti
force-pushed
the
dev/lalitm/heap-profile-3
branch
from
b8a5ce8 to
a676ba2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restructure heap_profile to use argparse subparsers. A shared
common_parser holds all flags; the 'android' subcommand inherits
from it via parents=[common].
When no subcommand is given the tool defaults to 'android', so all
existing invocations continue to work unchanged. This prepares the
tool for a future 'host' subcommand for local Linux profiling.