Open
Conversation
abhmen01
commented
Mar 25, 2026
abhmen01
commented
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
abhmen01
force-pushed
the
ui-arm-telemetry-pmu-recording-page
branch
from
b8e9f8c to
54a8119
Compare
Member
|
I think there is being some mixing up of commits. I see changes here that are also present in the other PRs. |
Add a new UI plugin for Arm CPU telemetry specifications. Introduces the ArmTelemetryManager interface for parsing, storing, and accessing the telemetry specifications. These specifications are unique to Arm CPU cores and include: - Events: PMU events available on the core. - Metrics: Computed from events for performance analysis. - Groups: Coherent collections of events or metrics. - Methodology: Describes how to conduct performance and micro-architecture analysis using the available metrics. The ArmTelemetryManager is initialized when the plugin is activated, so other plugins can access the shared telemetry spec registry.
Add `com.arm.ArmPmuRecorder` plugin that registers a new PMU recording subpage in the recording section to configure CPU PMUs to capture The PMU page lets users load local Arm telemetry CPU specs and create multiple recording configurations. Each configuration can select the CPU model, optional target CPU list, which PMUs and sampling configuration to use. In the UI, users can select PMUs to record by choosing metrics applicable to the selected CPU. Two metric views are available: a flat list and a tree view that follows the topdown specification for the chosen CPU. The plugin depends on ArmTelemetrySpecPlugin for spec parsing and validation, and updates the shared telemetry spec registry so the loaded specs are available to other Arm telemetry features.
abhmen01
force-pushed
the
ui-arm-telemetry-pmu-recording-page
branch
from
54a8119 to
2700df7
Compare
primiano
reviewed
Apr 21, 2026
| private static manager: ArmTelemetryManager; | ||
|
|
||
| static onActivate(app: App): void { | ||
| ArmTelemetrySpecPlugin.manager = new ArmTelemetryManagerImpl(app); |
Member
There was a problem hiding this comment.
why this static field out of curiosity? this class is already a singleton effectively
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.