Skip to content

trace_processor: Parse adreno_cmdbatch_retired/submitted events#5519

Merged
LalitMaganti merged 2 commits into
google:mainfrom
rossning92:tp-adreno-cmdbatch
Apr 23, 2026
Merged

trace_processor: Parse adreno_cmdbatch_retired/submitted events#5519
LalitMaganti merged 2 commits into
google:mainfrom
rossning92:tp-adreno-cmdbatch

Conversation

@rossning92
Copy link
Copy Markdown
Contributor

@rossning92 rossning92 commented Apr 21, 2026

Add custom parsing for kgsl adreno_cmdbatch_retired and adreno_cmdbatch_submitted ftrace events to display GPU slices in Perfetto UI.

Test: built and loaded trace from Adreno device, verified GPU slices appear under correct tracks in Perfetto UI:
image

Cross-validated with Qualcomm's Render stage trace (useful for GPU debugging but has large CPU and some GPU overhead):
image

@google-cla
Copy link
Copy Markdown

google-cla Bot commented Apr 21, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@rossning92 rossning92 force-pushed the tp-adreno-cmdbatch branch 2 times, most recently from 609564a to 47880c7 Compare April 21, 2026 05:27
@rossning92 rossning92 marked this pull request as ready for review April 21, 2026 05:46
@rossning92 rossning92 requested a review from a team as a code owner April 21, 2026 05:46
Comment thread src/trace_processor/importers/ftrace/ftrace_parser.cc Outdated
Comment thread src/trace_processor/importers/ftrace/ftrace_parser.cc Outdated
Comment thread src/trace_processor/importers/ftrace/ftrace_tokenizer.cc Outdated
Comment thread src/trace_processor/importers/ftrace/ftrace_tokenizer.cc Outdated
@rossning92 rossning92 force-pushed the tp-adreno-cmdbatch branch 2 times, most recently from 2503587 to d29f920 Compare April 21, 2026 23:54
Comment thread src/trace_processor/importers/ftrace/ftrace_tokenizer.cc Outdated
Comment thread src/trace_processor/importers/ftrace/ftrace_tokenizer.cc Outdated
Comment thread src/trace_processor/importers/ftrace/ftrace_tokenizer.cc Outdated
Comment thread src/trace_processor/importers/ftrace/ftrace_tokenizer.cc Outdated
Comment thread src/trace_processor/importers/ftrace/ftrace_tokenizer.cc
Comment thread ui/src/plugins/dev.perfetto.TraceProcessorTrack/slice_tracks.ts Outdated
Comment thread ui/src/plugins/dev.perfetto.TraceProcessorTrack/slice_tracks.ts Outdated
Add custom parsing for kgsl adreno_cmdbatch_retired and
adreno_cmdbatch_submitted ftrace events to produce GPU timeline slices
in the trace processor.
@rossning92
Copy link
Copy Markdown
Contributor Author

@sashwinbalaji could I get an extra approval with the last changes on reusing topLevelGroup: 'GPU' as suggested by Lalit. thanks for that!

@LalitMaganti LalitMaganti merged commit ffaeb0c into google:main Apr 23, 2026
16 of 17 checks passed
LalitMaganti added a commit that referenced this pull request May 8, 2026
…ts (#5519)" (#5793)

This reverts commit ffaeb0c.

Unfortunately this is necessary as this patch does *not* work on all
QCOM
devices: concretely, the events seem desynced from the render stage
events
which shouldn't really happen. Moreover, this also causes the raw ftrace
event
to be shifted which internal teams did not expect and were not happy
with.
LalitMaganti added a commit that referenced this pull request May 13, 2026
…ts (#5519)" (#5793)

This reverts commit ffaeb0c.

Unfortunately this is necessary as this patch does *not* work on all
QCOM
devices: concretely, the events seem desynced from the render stage
events
which shouldn't really happen. Moreover, this also causes the raw ftrace
event
to be shifted which internal teams did not expect and were not happy
with.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants