Skip to content

traced_probes: add wdog handler to finalize the trace gracefully#5755

Merged
primiano merged 5 commits into
mainfrom
dev/primiano/wdog2
May 7, 2026
Merged

traced_probes: add wdog handler to finalize the trace gracefully#5755
primiano merged 5 commits into
mainfrom
dev/primiano/wdog2

Conversation

@primiano
Copy link
Copy Markdown
Member

@primiano primiano commented May 6, 2026

This change introduces an option to install a watchdog handler.
Rather than killing the process directly, it allows the process
to gracefully handle the wathdog for up to 60 seconds.
We need this in traced_probes to give us a chance to serialize the
trace which will be picked up by traced to better debug these
watchdog failures.

Bug: b/496506220
Flag: trigger_perfetto_on_traced_probes_disconnect

@primiano primiano requested a review from a team as a code owner May 6, 2026 14:59
Base automatically changed from dev/primiano/wdog to main May 6, 2026 15:02
@primiano primiano requested a review from sashwinbalaji May 6, 2026 15:02
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

This change introduces an option to install a watchdog handler.
Rather than killing the process directly, it allows the process
to gracefully handle the wathdog for up to 60 seconds.
We need this in traced_probes to give us a chance to serialize the
trace which will be picked up by traced to better debug these
watchdog failures.

Bug: b/496506220
Flag: trigger_perfetto_on_traced_probes_disconnect
@primiano primiano force-pushed the dev/primiano/wdog2 branch from 2bf5b1c to 4405a62 Compare May 7, 2026 11:34
Comment thread include/perfetto/ext/base/metatrace_events.h
Comment thread src/traced/probes/probes_producer.cc Outdated
Comment thread include/perfetto/ext/base/watchdog.h
Comment thread src/base/watchdog_posix.cc
@primiano primiano merged commit 8a7e053 into main May 7, 2026
23 checks passed
@primiano primiano deleted the dev/primiano/wdog2 branch May 7, 2026 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants