[State] Add protos to describe state tracks and events [1/4]#6068
Open
etiennep-chromium wants to merge 13 commits into
Open
[State] Add protos to describe state tracks and events [1/4]#6068etiennep-chromium wants to merge 13 commits into
etiennep-chromium wants to merge 13 commits into
Conversation
Declare sibling_merge_behavior, sibling_merge_key, upid, and utid fields inside track_descriptor.proto to support Trace Processor sibling track merging and nested parent collapsible folders. TAG=agy CONV=abdcb83c-cd5a-4600-9a3b-de726c377bbf
…tate_proto_changes # Conflicts: # python/perfetto/protos/perfetto/trace/perfetto_trace_pb2.py # python/perfetto/protos/perfetto/trace/perfetto_trace_pb2.pyi
TAG=agy CONV=abdcb83c-cd5a-4600-9a3b-de726c377bbf
…e design TAG=agy CONV=abdcb83c-cd5a-4600-9a3b-de726c377bbf
🎨 Perfetto UI Builds
|
Extract StateDescriptor from track_descriptor.proto and declare it inside a new dedicated modular protobuf file state_descriptor.proto. Recompile and regenerate all Bazel, Android BP, C, and Python build descriptors. TAG=agy CONV=abdcb83c-cd5a-4600-9a3b-de726c377bbf
etiennep-chromium
force-pushed
the
dev/etiennep/state_proto_changes
branch
from
6ba6972 to
a5abc46
Compare
Member
|
LG but Primiano should also comment. |
…tate_proto_changes
| // Represents the state value for a state track. | ||
| message State { | ||
| // The built-in string state value. | ||
| optional string string_value = 1; |
Contributor
Author
There was a problem hiding this comment.
Come to think of it we might want to intern this, so either
- we add string_value_iid
- we reuse TrackEvent::name and TrackEvent::name_iid
WDYT?
Contributor
Author
There was a problem hiding this comment.
(I went with option 2)
etiennep-chromium
force-pushed
the
dev/etiennep/state_proto_changes
branch
from
4fe817d to
e96ff2c
Compare
etiennep-chromium
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on https://github.com/google/perfetto/blob/rfcs/0023-updatable-track-event.md
[1/4]: This PR adds state track and events proto, with no support, but minimal changes to make the build succeed.
For reference, this is the full implementation: #6068