Skip to content

Directly join owned threads on cleanup #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GregoryComer wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

Directly join owned threads on cleanup #92

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/pthreads.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -806,15 +806,15 @@ void pthreadpool_destroy(struct pthreadpool* threadpool) {
/* Tell all threads to stop. */
pthreadpool_release_all_threads(threadpool);

// Wait for any recruited threads to leave.
wait_on_num_recruited_threads(threadpool, 0);

if (!threadpool->executor.num_threads) {
/* Wait until all threads return */
for (size_t thread = 1; thread < threadpool->max_num_threads; thread++) {
pthreadpool_thread_join(threadpool->threads[thread].thread_object,
NULL);
}
} else {
/* Wait for executor-provided threads. */
wait_on_num_recruited_threads(threadpool, 0);
}

/* Release resources */
Expand Down