This repository was archived by the owner on Jan 10, 2023. It is now read-only.
Fixed the command IDs. Prior to this change the command IDs were usin…#10
Merged
fahhem merged 2 commits intogoogle:masterfrom Oct 27, 2015
Merged
Fixed the command IDs. Prior to this change the command IDs were usin…#10fahhem merged 2 commits intogoogle:masterfrom
fahhem merged 2 commits intogoogle:masterfrom
Conversation
…g the 4 letter code to generate the ID rather than the reversed 4 letter code.
Contributor
|
It's not reversed, it's just little-endian. For instance, STAT, the 'S' is the lowest-value byte, then 'T' and so-on. I made the constants for the doc before actually writing the code, which is when I actually wrote the MakeWireIDs function that creates the constants correctly. With that change, LGTM. |
…esentations of the 4-letter command codes
fahhem
added a commit
that referenced
this pull request
Oct 27, 2015
Fixed the command IDs in the protocol description
Contributor
|
Would you like to be in the CONTRIBUTORS file? If so, I'll accept either a merge request or just reply with your name and email |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…g the 4 letter code to generate the ID rather than the reversed 4 letter code.