This repository was archived by the owner on Jan 10, 2023. It is now read-only.
Package with distutils.core#2
Merged
alusco merged 3 commits intogoogle:masterfrom Oct 30, 2014
Merged
Conversation
Moved source for module "adb" to directory "adb". Added adb/__init__.py Updated and ran adb_test.py and fastboot_test.py. Added setup.py to build and install module.
There was a problem hiding this comment.
Google style is probably going to ask you to use import adb instead of using from imports.
Contributor
There was a problem hiding this comment.
No, adb_commands is a module, so this is fine. Google style simply says to not import things inside a module, but to import the module itself (for refactoring's sake).
Contributor
|
Awesome thanks! |
maruel
added a commit
to maruel/python-adb
that referenced
this pull request
Jun 17, 2016
Mimic self.Shell fallback from SetCPUScalingGovernor in SetCPUSpeed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first cut at packaging python-adb with distutils setup.
Moved source for module "adb" to directory "adb".
Added adb/init.py
Updated and ran adb_test.py and fastboot_test.py.
Added setup.py to build and install module.