This repository was archived by the owner on Jan 10, 2023. It is now read-only.
fix "checksum error" in adb_protocol.py#5
Closed
jameyhicks wants to merge 1 commit intogoogle:masterfrom
Closed
Conversation
Contributor
|
So it wasn't reading all of the data in before? That means the underlying Handle caused the problem by not obeying the length given. Which Handle did you see this with, Tcp or Usb? |
Contributor
Author
|
This problem was with a Tcp handle. Should this fix be moved to its BulkRead method? |
Contributor
|
No, looks like libusb1's bulkRead function has the same semantics around the length parameter. |
Contributor
|
LGTM |
maruel
added a commit
to maruel/python-adb
that referenced
this pull request
Jun 17, 2016
Fix fallback-to-shell in HighDevice.SetCPUSpeed()
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a problem where python-adb would report "checksum error" when receiving large amounts of data from the device.