This repository was archived by the owner on Jan 10, 2023. It is now read-only.
Fixed cli dropping rest of args?#6
Closed
tgalal wants to merge 1 commit intogoogle:masterfrom
Closed
Conversation
Contributor
|
Ah, this is because Pull has dest_file as a default arg to allow just getting the file's data directly. I'd prefer something that changed line 140 to: if num_args == 1 and method_name != 'pull': |
Contributor
Author
|
I think the idea is that cli introspects methods and generates usage out of it, and therefore shouldn't make assumptions about specific methods/ method names. There should be a better way to fix it while maintaining its intended design purpose. |
Contributor
|
Yeah, on second thought, just remove the line entirely. |
maruel
added a commit
to maruel/python-adb
that referenced
this pull request
Jun 17, 2016
CPU scaling fallback to scaling_[min|max]_freq, not cpuinfo_....
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For example:
dest was getting dropped and command always failed. Not sure if it's the correct way to fix it, but it worked for me.