Skip to content

Missing enum34 dependency requirement when installing for python2.7 #191

@lsix

Description

@lsix

Hi,

While updating python-fire in NixOS, we have realized that it should depend on enum34 when installing for python version older than 3.4.

https://github.com/google/python-fire/blob/master/fire/docstrings.py#L61 has import enum which was introduced in python3.4. This is available to other versions of python via enum34, but not stated in setup.py.

Something like this should solve the problem:

diff --git a/setup.py b/setup.py
index 5ddbb48..86bb171 100644
--- a/setup.py
+++ b/setup.py
@@ -15,6 +15,7 @@
 """The setup.py file for Python Fire."""
 
 from setuptools import setup
+import sys
 
 
 LONG_DESCRIPTION = """
@@ -32,7 +33,7 @@ A library for automatically generating command line interfaces.""".strip()
 DEPENDENCIES = [
     'six',
     'termcolor',
-]
+] + (['enum34'] if sys.version < (3.4)  else [])
 
 TEST_DEPENDENCIES = [
     'hypothesis',

Hope this helps.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions