Display dict of namedtuples

[robertvazan]

Fire nicely prints a dict of dicts using one line per inner dict. When I try to do the same with dict of namedtuples (which otherwise behave like dicts after #161), I just get a help page listing all the dict keys. When I specify a dict key, then that namedtuple is printed. I would prefer all namedtuples in the dict to be printed when no key is specified.

[robertvazan]

BTW, it would be probably a good idea to display namedtuple itself like a dict, but then this somewhat depends on what namedtuples are commonly used for. Mine would be more readable with field labels.

[dbieber]

Good idea.

The relevant code to change is:

python-fire/fire/core.py

Lines 258 to 261 in c830177

	elif isinstance(result, dict) and value_types.IsSimpleGroup(result):
	print(_DictAsString(result, verbose))
	elif isinstance(result, tuple):
	print(_OneLineResult(result))

and

python-fire/fire/value_types.py

Line 44 in c830177

def IsSimpleGroup(component):

[armingh2000]

I've been working on this issue for a while.I think that namedtuples are not correctly handled yet.
In inspectutils.py, the function IsNamedTuple is implemented wrong. Because namedtuple is not an instance of tuple ( isinstance(a namedtuple variable, tuple) is false). I wonder how it works on some namedtuples?
If we want to handle namedtuples, are we focusing on only collections module or also other modules as well?

[dbieber]

Because namedtuple is not an instance of tuple ( isinstance(a namedtuple variable, tuple) is false).

I just confirmed in Python 3:

In [2]: import collections                                                                                                                                         
In [3]: Point = collections.namedtuple('Point', ['x', 'y'])                                                                                                        
In [4]: x = Point(1,2)                                                                                                                                             
In [5]: isinstance(x, tuple)
Out[5]: True

Where did you see a namedtuple that was not an instance of tuple?

If we want to handle namedtuples, are we focusing on only collections module or also other modules as well?

Are there other collections or types you're thinking about? We don't have a clearly articulated scope. NamedTuples are important to handle well because they're commonly used.

[armingh2000]

I just confirmed in Python 3:
In [2]: import collections
In [3]: Point = collections.namedtuple('Point', ['x', 'y'])
In [4]: x = Point(1,2)
In [5]: isinstance(x, tuple)
Out[5]: True

Yes. You're right. I made a mistake in passing the right variable to it.

Are there other collections or types you're thinking about? We don't have a clearly articulated scope. NamedTuples are important to handle well because they're commonly used.

I've used typing.NamedTuple before. Which is a typed version of collection.namedtuple:(https://docs.python.org/3/library/typing.html#typing.NamedTuple)

It's Handled well here, like a collections.namedtuple object.

[armingh2000]

@dbieber
I made a simple change and made a pull request. I think it'll do the job. Can you check?