Skip to content
This repository was archived by the owner on Oct 27, 2022. It is now read-only.

Fixes so windows can pass tests#20

Closed
rp-tanium wants to merge 1 commit intogoogle:masterfrom
tanium:win_test_pass
Closed

Fixes so windows can pass tests#20
rp-tanium wants to merge 1 commit intogoogle:masterfrom
tanium:win_test_pass

Conversation

@rp-tanium
Copy link

  • Pass timeout in seconds to exception in windows wait function
  • Added a small sleep to test_check_output_timeout to avoid busyloop on failures.
  • Fixed cases where return code was expected to be -9 (is 1 on windows) after a kill
  • Ensured skip test directive for signals tests and cwd tests.
  • Fixed case where orig_timeout was not passed to TimeoutExpired.

* pass timeout in seconds to exception in windows wait function
* added a small sleep to test_check_output_timeout to avoid busyloop on failures.
* fixed cases where return code was expected to be -9 (is 1 on windows) after a kill
* ensured skip test directive for signals tests and cwd tests.
* fixed case where orig_timeout was not passed to TimeoutExpired.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@gpshead
Copy link
Contributor

gpshead commented Oct 20, 2017

similar changes from upstream committed, the testsuite now passes.

@gpshead gpshead closed this Oct 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants