This repository was archived by the owner on Oct 27, 2022. It is now read-only.
Closed
Conversation
…l classes.
Checked with this snippet:
```
import subprocess, subprocess32
for name in dir(subprocess32):
new_value = getattr(subprocess32, name)
old_value = getattr(subprocess, name, None)
if old_value is not None and isinstance(old_value, type):
assert issubclass(new_value, old_value), "Incompatible type: {0}".format(name)
```
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While the README.md suggests that subprocess32 can replace subprocess, this does not seem the case with a current CPython 2.7 since multiprocessing uses a protected function in subprocess not provided by subprocess32.
Also just doing
import subprocess32 as subprocesscauses problems if other code still imports subprocess directly and tries to catch exceptions like CalledProcessError. This commit tries to mimic the original API more closely.