Google sync#1008
Merged
Merged
Conversation
PiperOrigin-RevId: 395756826
Whether the error appears on the decorator line or the classdef line changes between versions. We should probably change pytype to pick a consistent location, but for now, inheriting from object fixes this. PiperOrigin-RevId: 395788178
See https://github.com/google/pytype/runs/3560609733?check_suite_focus=true. pylint is complaining because Class._new_instance takes a 'container' argument. PiperOrigin-RevId: 395788561
PiperOrigin-RevId: 395790403
This flag was already a no-op as of the release earlier today. PiperOrigin-RevId: 395795803
…e arglist. PiperOrigin-RevId: 395819489
The pyi file just records the default as "True" or "False" depending on whether the field has a default or not, in keeping with the general practice around variable defaults. PiperOrigin-RevId: 395968657
This consolidates and avoids repeating some information. PiperOrigin-RevId: 396401242
This makes enabling the enum overlay easier by allowing files that raise errors when analyzed by the overlay completely ignore the changes caused by the overlay. Also fixes several other issues: - enum_overlay: check that `_generate_next_value_` is a callable. - test_enums: enable almost all tests by default. - enum.pytd: clean up incorrect comments. PiperOrigin-RevId: 396452142
…tarargs. PiperOrigin-RevId: 396470728
… type. Previously we were discarding bindings from `x` that did not match `type` but not adding any new types. However, in keeping with the analogy to `assert isinstance(x, type)`, we should simply discard existing bindings and create a new one with the asserted type. PiperOrigin-RevId: 396645440
Using two type stubs for enum lead to issues with names. Instead, use the older type stub and remove the unneeded `__getattribute__` defs when the overlay is enabled. PiperOrigin-RevId: 396688345
PiperOrigin-RevId: 396691381
Support added for python literals and function calls (for type constructors). Function calls are converted to dicts, and then all annotations are converted to their repr strings to be stored in pytd.Annotated nodes. Annotations are not yet preserved for round-tripping. Also moves around some code to fix dependency issues. PiperOrigin-RevId: 396696017
This is preliminary work for better support of attr.ib converters, which interact with the field type in complicated ways. PiperOrigin-RevId: 396945453
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.