Google sync#1299
Merged
Merged
Conversation
Improves matcher.compute_matches so that we can switch fully from compute_subst to compute_matches for SignedFunction and its subclasses (most importantly, InterpreterFunction!). * Passes `alias_map` all the way through to compute_one_match to preserve aliases in subst. * Merges `subst` dictionaries when multiple parameters produce non-empty substs by factoring out and reusing the matcher's existing code for checking that possible TypeVar substitutions are consistent with one another. * Adds subst deduplication logic so that merging doesn't blow up. * Tracks seen type parameters in the matcher so that we can access bounds and constraints during merging. * Copies the code for preserving `self` substitutions from compute_subst. * Sets matcher._error_subst for better error messages. PiperOrigin-RevId: 478906124
Oops. PiperOrigin-RevId: 479096311
PiperOrigin-RevId: 479152490
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.