Google sync#1318
Merged
Merged
Conversation
…] type defintions correctly. Testing showed that round-tripping Literal["\0"] did not work properly, as the parser was using a simple regex to extract the string contents, which didn't understand how to do backslash escapes appropriately. Using the `ast` module by way of `pyi.evaluator.eval_string_literal(string)` we interpret the string correctly. PiperOrigin-RevId: 487285573
PiperOrigin-RevId: 487315681
This way we don't have to expand the visibility of the former. PiperOrigin-RevId: 487337632
* Fixes a bug where a local variable's original binding(s) weren't visible, by forwarding them to the node at which the TypeGuard function was called. * Fixes a bug where TypeGuard did not work for globals that were annotated but not defined, by having vm._load_annotation update members and _var_names. PiperOrigin-RevId: 487391804
PiperOrigin-RevId: 487622881
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.