Google sync#1329
Merged
Merged
Conversation
With the previous logic, if the module prefix didn't have '.' in it, we would raise a KeyError even though it should have been found. PiperOrigin-RevId: 492557921
… possible.
I found user code that is doing stuff like:
T1 = TypeVar('T1')
T2 = TypeVar('T2', T1)
=/ Pytype was just silently downgrading types to Any. It's better to warn the
user that this is invalid. However, converting to Any as soon as we notice an
invalid TypeVar causes follow-on errors when attempting to use that TypeVar in
a generic class definition. As long as we have the TypeVar name, we can instead
create an unbounded, unconstrained TypeVar.
PiperOrigin-RevId: 492571068
…etection. PiperOrigin-RevId: 492572222
The abstract matcher already applies these expansions (parameter type `float` accepts both `int` and `float`, etc.), so the only thing ExpandCompatibleBuiltins was doing was over-applying the expansions to things like attributes and variables. PiperOrigin-RevId: 492574853
PiperOrigin-RevId: 492583504
PiperOrigin-RevId: 492587469
builtins.type.__new__ and subprocess.Popen.__new__ have similar custom implementations. This change creates a new base class for them both to inherit from. For now, the _METHOD_NAME attribute is unnecessary (since it's always __new__), but in the upcoming typeshed update, typeshed switches to defining Popen.__init__, so we'll soon need this attribute. This will also make it easier to add a custom implementation of abc.ABCMeta.__new__, which again will be needed for updating typeshed. PiperOrigin-RevId: 492589488
They need to be annotated as tuple and dict, not Any. PiperOrigin-RevId: 493121382
- Adds a "class" field to Cytoscape nodes, making it much easier to filter them. - Adds a little bit of node separation in the dagre layout engine, so nodes don't stack up as much. Makes labels easier to read, at the cost of a slightly wider tree. - Fixes a small nit in cfg_visualizer.py re: unnecessary variables. PiperOrigin-RevId: 493161863
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.