Google sync#1401
Merged
Merged
Conversation
The initial version provides type checking for fiddle config classes wrapping dataclasses; all other cases are treated as Any. PiperOrigin-RevId: 517521440
…info file for every failed module load. This log is excessive, especially since we use the module loader to try imports that might or might not be modules, walking our way up the path, so we get stuff like ``` DEBUG:pytype.load_pytd Trying to import 'abc.ABCMeta' WARNING:pytype.imports.module_loader Couldn't import module abc.ABCMeta 'abc.ABCMeta' in (path=['']) imports_map: 903 items [903 lines of import map entries] ``` If it turns out we really need this info we can log the path to the file instead. PiperOrigin-RevId: 517540885
Makes sure all three of `fiddle.Config(Foo)`, `fiddle.Config[Foo]` in a type annotation, and `fiddle.Config[Foo]` imported from a pyi file return the same `fiddle_overlay.Config` instance every time they are encountered. PiperOrigin-RevId: 518028362
PiperOrigin-RevId: 518118737
Working towards better display of queries. Next step: text explaining each step. PiperOrigin-RevId: 518119835
PiperOrigin-RevId: 518351736
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.