Skip to content

Add breakpoint to the supported builtin methods#997

Closed
Jrryy wants to merge 2 commits into
google:masterfrom
Jrryy:add-breakpoint-to-stubs
Closed

Add breakpoint to the supported builtin methods#997
Jrryy wants to merge 2 commits into
google:masterfrom
Jrryy:add-breakpoint-to-stubs

Conversation

@Jrryy

@Jrryy Jrryy commented Sep 1, 2021

Copy link
Copy Markdown
Contributor

Resolves #994

@google-cla

google-cla Bot commented Sep 1, 2021

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla Bot added the cla: no label Sep 1, 2021
@Jrryy

Jrryy commented Sep 1, 2021

Copy link
Copy Markdown
Contributor Author

@googlebot I signed it!

@google-cla google-cla Bot added cla: yes and removed cla: no labels Sep 1, 2021
@rchen152

rchen152 commented Sep 4, 2021

Copy link
Copy Markdown
Contributor

Thanks for the PR! I'm importing it now for internal review; it should get merged sometime on Tuesday (Monday is a U.S. holiday).

@rchen152 rchen152 closed this in 561fb05 Sep 7, 2021
rchen152 added a commit that referenced this pull request Sep 9, 2021
I forgot to double-check the signature of breakpoint
(https://docs.python.org/3/library/functions.html#breakpoint) before accepting
PR #997.

PiperOrigin-RevId: 395337303
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

false positive for built-in function breakpoint()

2 participants