[QwixOpId] Improve op_id generation for Linen and NNX modules.#200
Merged
copybara-service[bot] merged 1 commit intomainfrom Jan 27, 2026
Merged
[QwixOpId] Improve op_id generation for Linen and NNX modules.#200copybara-service[bot] merged 1 commit intomainfrom
op_id generation for Linen and NNX modules.#200copybara-service[bot] merged 1 commit intomainfrom
Conversation
11f9f08 to
c735080
Compare
op_id generation for Linen and NNX modules.
Update the `_get_op_id` function to use `module.scope` as the tracking key for Linen and the `module` as tracing key for NNX(same as before). This ensures unique op IDs are generated even when module instances are shared or reused within a model, preventing conflicts in `aux_data` tracking. PiperOrigin-RevId: 861808171
c735080 to
dc770ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[QwixOpId] Improve
op_idgeneration for Linen and NNX modules.Update the
_get_op_idfunction to usemodule.scopeas the tracking key for Linen and themoduleas tracing key for NNX(same as before). This ensures unique op IDs are generated even when module instances are shared or reused within a model, preventing conflicts inaux_datatracking.