[QwixNnxDataType] Register Qwix metadata and array structures as NNX data types.#218
Merged
copybara-service[bot] merged 1 commit intomainfrom Feb 20, 2026
Merged
[QwixNnxDataType] Register Qwix metadata and array structures as NNX data types.#218copybara-service[bot] merged 1 commit intomainfrom
copybara-service[bot] merged 1 commit intomainfrom
Conversation
470304d to
930b372
Compare
…data types. This change is required to maintain compatibility with the stricter trace-context and graph validation logic introduced in Flax NNX. Following that update, `nnx.graph.flatten` and other graph utilities now strictly enforce the boundary between dynamic `data` and `static` metadata. Any attribute that is not an `nnx.Variable`, `nnx.Module`, or an explicitly registered data type defaults to `static`. If such an attribute contains JAX arrays or tracers, NNX raises a ValueError. We register the following types as dynamic data nodes to ensure they are correctly handled during graph traversal (`nnx.split`, `nnx.state`, `nnx.update`): - QArray (in qarray.py) - PaddedQArray (in padded_ptq.py) - WithAux (in ptq.py) - WithAwqScale (in awq.py) PiperOrigin-RevId: 872659797
930b372 to
e292088
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[QwixNnxDataType] Register Qwix metadata and array structures as NNX data types.
This change is required to maintain compatibility with the stricter trace-context
and graph validation logic introduced in Flax NNX.
Following that update,
nnx.graph.flattenand other graph utilities now strictlyenforce the boundary between dynamic
dataandstaticmetadata. Any attribute that is not annnx.Variable,nnx.Module, or an explicitly registered data typedefaults to
static. If such an attribute contains JAX arrays or tracers, NNXraises a ValueError.
We register the following types as dynamic data nodes to ensure they are
correctly handled during graph traversal (
nnx.split,nnx.state,nnx.update):